cleanup(deps): drop cypress peer dependency #725
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
force-pushed
the
cleanup/drop-cypress-peer-dependency
branch
from
395abd7 to
c7d5acb
Compare
See #601. This package is also used in playwright tests. Remove the peer dependency to avaoid automatic installation of cypress. I also considered making it an optional dependency. But then it would still be installed by default. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
cleanup/drop-cypress-peer-dependency
branch
from
c7d5acb to
e02bdd7
Compare
7 tasks
Contributor
How ? |
Contributor
Author
Forms uses it to start and configure the nextcloud server playwright runs against and to run commands on the server. I don't know if it's also used in other repos in that way - but I'm starting with the use in forms as a template for adding playwright tests to the |
Contributor
|
Time to rename that repo then :) I would prefer a PR that removes cypres and also rename + fix #601 entirely. |
Contributor
Author
|
Moving on with this in #601 and a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #601.
This package is also used in playwright tests.
Remove the peer dependency to avaoid automatic installation of cypress.
I also considered making it an optional dependency. But then it would still be installed by default.