refactor!: migrate from cancelable promise to AbortSignal #1428
+52
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
CarlSchwan
approved these changes
Dec 16, 2025
AbortSignal (provided by AbortController) is the standard way of doing this and is in-line with how e.g. the webdav library, axios or native fetch work. Also `cancelable-promise` is deprecated in favor of this. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
refactor/migrate-abort-controller
branch
from
493656b to
f0b387a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1428 +/- ##
==========================================
- Coverage 91.21% 91.02% -0.19%
==========================================
Files 24 24
Lines 694 691 -3
Branches 189 192 +3
==========================================
- Hits 633 629 -4
Misses 50 50
- Partials 11 12 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbortSignal (provided by AbortController) is the standard way of doing this and is in-line with how e.g. the webdav library, axios or native fetch work.
Also
cancelable-promiseis deprecated in favor of this.