fix(registry): Prevent prototype polluting #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
approved these changes
Feb 12, 2025
susnux
changed the title
Contributor
Author
|
@ShGKme note that this is generated by copilot (I am testing their new security features). |
susnux
added
type: bug
From CodeQL: > Most JavaScript objects inherit the properties of the built-in Object.prototype object. Prototype pollution is a type of vulnerability in which an attacker is able to modify Object.prototype. > Since most objects inherit from the compromised Object.prototype object, the attacker can use this to tamper with the application logic, and often escalate to remote code execution or cross-site scripting. To fix the problem, we need to ensure that the `appId` cannot be used to modify the `Object.prototype`. Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
alert-autofix-1
branch
from
635ce51 to
8ebdc9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/nextcloud-libraries/nextcloud-l10n/security/code-scanning/1
To fix the problem, we need to ensure that the
appIdcannot be used to modify theObject.prototype. This can be achieved by validating theappIdbefore using it as a key in the object assignment. We will reject anyappIdthat matches__proto__,constructor, orprototype.