fix: use configured log level even if window._oc_debug is set
#906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
changed the title
window._oc_debug is setwindow._oc_debug is set
max-nextcloud
changed the title
window._oc_debug is setwindow._oc_debug is set
This allows using less verbose logging in the frontend while using debug features on the server like navigating the dav endpoints. It still works the same on NC24 and lower where log levels where not exposed on the frontend. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
fix/do-not-force-debug-logging
branch
from
fdff95f to
c7a9de0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #906 +/- ##
==========================================
- Coverage 98.41% 98.38% -0.03%
==========================================
Files 4 4
Lines 63 62 -1
Branches 13 13
==========================================
- Hits 62 61 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
susnux
approved these changes
Nov 7, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
This makes sense to me!
The fallback is preserved but its not overridden if already configured, nice!
juliusknorr
approved these changes
Nov 7, 2025
susnux
changed the title
window._oc_debug is setwindow._oc_debug is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using less verbose logging in the frontend
while using debug features on the server like navigating the dav endpoints.