Skip to content

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 7, 2026

batchUpload wraps all the files to upload into a meta Upload instance and adds it to the uploading queue for:

  • having a status of the entire upload to be sent in the notify
  • having uploading in process in the queue even before the first file is uploading, during the conflict checking

This queue is emptied when the job queue is finished.

However, when all the files to upload are skipped, there is no job in the job queue, so it never finishes and never cleans the upload queue. The meta-upload exists in the upload queue but does not have a corresponding job in the job queue (it is not a real upload).

A fix: as this is an artificial meta upload - also manually remove it from the queue.

Alternatives:

  1. Do not add it to the queue at all (but then there is no progress during conflict check which may take a long time)
  2. Rework uploading to remove the meta upload entirely, having only real uploading

@ShGKme ShGKme requested review from skjnldsv and susnux January 7, 2026 17:24
@ShGKme ShGKme self-assigned this Jan 7, 2026
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews labels Jan 7, 2026
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.69%. Comparing base (093cc82) to head (fe2bced).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2002      +/-   ##
==========================================
+ Coverage   36.16%   39.69%   +3.53%     
==========================================
  Files          20       20              
  Lines        1745     1746       +1     
  Branches       83       91       +8     
==========================================
+ Hits          631      693      +62     
+ Misses       1114     1053      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skipping a duplicate does not remove the upload progress bar

4 participants