Skip to content

Fix jsdoc: Add missing documentation for events #3545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Fix jsdoc: Add missing documentation for events #3545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/NcBreadcrumb/NcBreadcrumb.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,8 @@ export default {
}
/**
* Event emitted when something is dropped on the breadcrumb.
*
* @type {null}
* @param {Event} event The DOM drop event
* @param {(string|object)} to The `to` prop or, if not set, the `href` prop
*/
this.$emit('dropped', e, this.to || this.href)
this.$parent.$emit('dropped', e, this.to || this.href)
Expand Down
3 changes: 2 additions & 1 deletion src/components/NcBreadcrumbs/NcBreadcrumbs.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,8 @@ export default {
/**
* Event emitted when something is dropped on the breadcrumb.
*
* @type {null}
* @param {Event} e the drop DOM event
* @param {string} path The path of the breadcrumb
*/
this.$emit('dropped', e, path)
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/NcListItem/NcListItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ export default {
},

/**
* Id for the <a> element
* Id for the `<a>` element
*/
anchorId: {
type: String,
Expand Down