Skip to content

7.2.0 #3557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2022
Merged

7.2.0 #3557

merged 1 commit into from
Dec 9, 2022

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Dec 9, 2022 •
edited
Loading

Fix #3533

NcHeaderMenu is in, we need a minor to follow semver.
I will deprecate 7.1.0 in npm afterwards

v7.2.0 (2022-12-09)

Full Changelog

🚀 Enhancements

🐛 Fixed bugs

  • Add button role for NcButton with href #3532 (Pytal)
  • Fix focus returning to top of page instead of actions toggle button #3530 (Pytal)
  • Fix icon repeat and position for AppNavigationItem #3539 (skjnldsv)
  • Fix jsdoc: Add missing documentation for events #3545 (susnux)
  • Increase input field border contrast #3551 (Pytal)
  • Increase NcSelect border contrast #3552 (Pytal)
  • Revert "fix sidebar scrolling for small displays" #3559 (skjnldsv)
  • Scope global #content styles via extra class #3537 (st3iny)

@skjnldsv skjnldsv self-assigned this Dec 9, 2022
@skjnldsv skjnldsv added the 2. developing Work in progress label Dec 9, 2022
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 9, 2022
@skjnldsv
7.2.0
366773e 
Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv changed the title 7.1.1 7.2.0 Dec 9, 2022
@skjnldsv skjnldsv requested a review from PVince81 December 9, 2022 08:58
PVince81
PVince81 approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skjnldsv skjnldsv merged commit 7a97cc1 into master Dec 9, 2022
@skjnldsv skjnldsv deleted the release/v7.1.1 branch December 9, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@szaimen szaimen Awaiting requested review from szaimen

+1 more reviewer

@PVince81 PVince81 PVince81 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sidebar was turned into scrollable item which is a breaking change in 7.1.0 needs to bump to 8.0 or work differently

3 participants

@skjnldsv @nickvergessen @PVince81