Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 20, 2023

Bumps @nextcloud/l10n from 1.6.0 to 2.0.1.

Release notes

Sourced from @​nextcloud/l10n's releases.

v2.0.1

2.0.1 - 2023-01-19

Full Changelog

Fixed

Changed

  • Dependency updates

v2.0.0

2.0.0 - 2023-01-12

Full Changelog

Changed

From 2.0.0, this package is standalone and do not rely on window OC variables to function.

Fixed

  • Provide all translation related functions #542 (susnux)
  • Fix building and deploying documentation #546 (susnux)

v2.0.0-beta.0

2.0.0-beta.0 - 2023-01-11

Full Changelog

Fixed

  • Provide all translation related functions #542 (susnux)
  • Fix building and deploying documentaton #546 (susnux)
Changelog

Sourced from @​nextcloud/l10n's changelog.

2.0.1 - 2023-01-19

Full Changelog

Fixed

Changed

  • Dependency updates

2.0.0 - 2023-01-12

Full Changelog

Changed

From 2.0.0, this package is standalone and do not rely on window OC variables to function.

Fixed

  • Provide all translation related functions #542 (susnux)
  • Fix building and deploying documentation #546 (susnux)
Commits
  • 9bfc0b7 Merge pull request #564 from nextcloud/release/2.0.1
  • b53c876 chore(release): v2.0.1
  • 0fe2ab4 Merge pull request #556 from nextcloud/fix-standalone-register
  • 4f53d4f Merge pull request #562 from nextcloud/fix/typings-tsconfig
  • 781e23a Merge pull request #563 from nextcloud/fix/npmignore
  • 8201098 fix(config): fix npmignore config
  • 6bf77eb fix(config): fix tsconfig out dir typings
  • 71a4f43 Merge pull request #559 from nextcloud/dependabot/npm_and_yarn/typedoc-0.23.24
  • 02d7682 Merge pull request #557 from nextcloud/dependabot/npm_and_yarn/ts-jest-29.0.5
  • c1f2f2f build(deps-dev): Bump typedoc from 0.23.23 to 0.23.24
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by skjnldsv, a new releaser for @​nextcloud/l10n since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @raimund-schluessler.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Jan 20, 2023
@max-nextcloud
Copy link
Contributor

I tried to replace the l10n import in src/l10n.js with

import { getGettextBuilder } from '@nextcloud/l10n/gettext'

But lint still fails with:

error  Unable to resolve path to module '@nextcloud/l10n/gettext'

@raimund-schluessler
Copy link
Contributor

@susnux Any idea about the failing eslint here? I adjusted the path to

import { getGettextBuilder } from '@nextcloud/l10n/gettext'

but eslint still complains with this error:

/home/runner/work/nextcloud-vue/nextcloud-vue/src/l10n.js
Error:   1:35  error  Unable to resolve path to module '@nextcloud/l10n/gettext'  import/no-unresolved

@susnux
Copy link
Contributor

susnux commented Jan 30, 2023

@susnux Any idea about the failing eslint here? I adjusted the path to

Related to the resolve packe used by the eslint rule, which does not support "modern" node resolve (node 13):
See browserify/resolve#224
And import-js/eslint-plugin-import#1810

I file a PR against eslint-config adding a fix for this false positive.

@raimund-schluessler
Copy link
Contributor

@susnux Any idea about the failing eslint here? I adjusted the path to

Related to the resolve packe used by the eslint rule, which does not support "modern" node resolve (node 13): See browserify/resolve#224 And import-js/eslint-plugin-import#1810

I file a PR against eslint-config adding a fix for this false positive.

Thanks for the insight. Should we just ignore the false-positive for now then?

@susnux
Copy link
Contributor

susnux commented Jan 31, 2023

PR: nextcloud-libraries/eslint-config#452

Edit: Merged and released, we can now update our config (#3702)

@raimund-schluessler
Copy link
Contributor

@dependabot recreate

Bumps [@nextcloud/l10n](https://github.com/nextcloud/nextcloud-l10n) from 1.6.0 to 2.0.1.
- [Release notes](https://github.com/nextcloud/nextcloud-l10n/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-l10n/blob/master/CHANGELOG.md)
- [Commits](nextcloud-libraries/nextcloud-l10n@v1.6.0...v2.0.1)

---
updated-dependencies:
- dependency-name: "@nextcloud/l10n"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/nextcloud/l10n-2.0.1 branch from 0aa7f56 to bf7f3ba Compare January 31, 2023 16:20
Signed-off-by: Raimund Schlüßler <[email protected]>
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot dependabot bot merged commit df84d3d into master Jan 31, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/nextcloud/l10n-2.0.1 branch January 31, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants