[next] chore(NcBreadcrumbs): simplify code#5068
Merged
raimund-schluessler merged 3 commits intonextfrom Jan 31, 2024
Merged
Conversation
raimund-schluessler
changed the title
raimund-schluessler
added
the
feature: breadcrumbs
raimund-schluessler
force-pushed
the
chore/noid/breadcrumbs-cleanup
branch
from
0bf0bc0 to
1ddda89
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
chore/noid/breadcrumbs-cleanup
branch
from
1ddda89 to
c9d2242
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
chore/noid/breadcrumbs-cleanup
branch
from
c9d2242 to
a57a912
Compare
Contributor
Author
|
Resolved conflicts. |
Antreesy
approved these changes
Jan 31, 2024
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Seems legit, code changes should be equivalent
Haven't work with array refs in Vue 3, but know they should work 🦭
Contributor
Author
|
These random Cypress failures are annoying. Six runs now and always a different test failing. |
Contributor
Yes that is super annoying, Cypress knows of that flaky tests for couple of month but is not considered to be something worth to fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
This PR simplifies the code of
NcBreadcrumbs.Array.spliceinstead ofslice -> push -> slice -> concat. This should speed up the render function a bit.breadcrumbsRefsobject to be an array, which safes us from runningObject.valuesat two spots.I didn't send this PR against
masterto not introduce any issues in the stable branch. Also, merging changes to vue2 render functions intonextis always a pain. In case you insist, we could of course also improve it formaster.No visual or functional changes.
Best viewed as https://github.com/nextcloud-libraries/nextcloud-vue/pull/5068/files?diff=unified&w=1