Skip to content

Comments

fix(NcActions): adjust wrapper names#5187

Closed
raimund-schluessler wants to merge 1 commit intochore/noid/merge-master-nextfrom
fix/noid/action-wrappers
Closed

fix(NcActions): adjust wrapper names#5187
raimund-schluessler wants to merge 1 commit intochore/noid/merge-master-nextfrom
fix/noid/action-wrappers

Conversation

@raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Jan 30, 2024

☑️ Resolves

If we adjust the action wrapper names to start with NcAction (or alternatively relax the "what is an action condition"), then we at least get the same (broken) behaviour for next as we get for master. Would that be an improvement?

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added this to the 9.0.0-alpha.1 milestone Jan 30, 2024
@raimund-schluessler raimund-schluessler added bug Something isn't working question Further information is requested feature: actions Related to the actions components labels Jan 30, 2024
@raimund-schluessler raimund-schluessler marked this pull request as draft January 30, 2024 22:07
@raimund-schluessler raimund-schluessler changed the base branch from chore/noid/merge-master-next to next January 30, 2024 22:07
@raimund-schluessler raimund-schluessler changed the base branch from next to chore/noid/merge-master-next January 30, 2024 22:09
@ShGKme
Copy link
Contributor

ShGKme commented Jan 30, 2024

If we adjust the action wrapper names to start with NcAction (or alternatively relax the "what is an action condition"), then we at least get the same (broken) behaviour for next as we get for master. Would that be an improvement?

I don't think we should provide such an interface for the component.

It doesn't solve the issue for wrappers over list of components or wrappers with dynamic content (see: #5184 (comment)).

It doesn't solve an issue with limitations anyway (e.g., it is important to separate NcActionButton from NcActionButtonGroup for both inline buttons and a11y).

A solution based on name is possible now already without prefix, component users can pass component with exact name NcActionButton and ect., when it is not a list and static.

While we don't have an app migrating to Vue 3 that suffers from this issue, I'd try to solve.

@raimund-schluessler
Copy link
Contributor Author

Ok. Fine with me.

@raimund-schluessler raimund-schluessler deleted the fix/noid/action-wrappers branch January 31, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working feature: actions Related to the actions components question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants