-
Notifications
You must be signed in to change notification settings - Fork 96
perf(NcTimezonePicker): use Intl to reduce self-size from 206kb to 2kb #7522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
st3iny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works.
Antreesy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise good
|
/backport to stable8 |
|
The backport to # Switch to the target branch and update it
git checkout stable8
git pull origin stable8
# Create the new backport branch
git checkout -b backport/7522/stable8
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 465fcfb6 958351a2
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7522/stable8Error: Failed to check for changes with origin/stable8: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
☑️ Resolves
<NcTimezonePicker>is the 8th largest component<NcDateTimePicker>large@nextcloud/timezonesIntlNcSelect) drops from 200kb to 3kb (98.5% reduction)🖼️ Screenshots
🏁 Checklist
stable8for maintained Vue 2 version or not applicable