Skip to content

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Sep 17, 2025

☑️ Resolves

  • Ref: Library size report #7196
    • <NcTimezonePicker> is the 8th largest component
    • It also makes <NcDateTimePicker> large
  • Most of the component size is the complete TZ database from @nextcloud/timezones
  • With a wide Intl support, it can be replaced with Intl
  • Result: component self-size (without NcSelect) drops from 200kb to 3kb (98.5% reduction)

🖼️ Screenshots

Component Before After
NcSelect 100.95 kb 100.95 kb
NcTimezonePicker 306.93 kb 103.00 kb (🔻 66.44%)
NcDateTimePicker 555.23 kb 350.58 kb (🔻 36.86%)
NcTimezonePicker - NcSelect 206.00 kb 2.05 kb (🔻 99.00%)
NcDateTimePicker - NcSelect 454.28 kb 249.63 kb (🔻 45.05%)

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@ShGKme ShGKme added this to the 9.0.0-rc.10 milestone Sep 17, 2025
@ShGKme ShGKme requested review from Antreesy and st3iny September 17, 2025 10:57
@ShGKme ShGKme self-assigned this Sep 17, 2025
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: datepicker Related to the date/time picker component feature: timezone-picker labels Sep 17, 2025
Copy link
Contributor

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise good

@ShGKme ShGKme merged commit 7ce947f into main Sep 17, 2025
25 checks passed
@ShGKme ShGKme deleted the perf/NcTimezonePicker branch September 17, 2025 16:54
@ShGKme
Copy link
Contributor Author

ShGKme commented Sep 30, 2025

/backport to stable8

@backportbot
Copy link

backportbot bot commented Sep 30, 2025

The backport to stable8 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable8
git pull origin stable8

# Create the new backport branch
git checkout -b backport/7522/stable8

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 465fcfb6 958351a2

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7522/stable8

Error: Failed to check for changes with origin/stable8: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request bug Something isn't working feature: datepicker Related to the date/time picker component feature: timezone-picker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants