Skip to content

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 8, 2026

☑️ Resolves

  • Fix incompatibility issue coming from focus-trap 7.7.0
  • Pin exact version until it's solved
  • Add ignore pattern to dependabot.yml

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@Antreesy Antreesy added this to the 9.4.0 milestone Jan 8, 2026
@Antreesy Antreesy requested a review from ShGKme January 8, 2026 21:10
@Antreesy Antreesy self-assigned this Jan 8, 2026
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Jan 8, 2026
@codecov

This comment was marked as off-topic.

ShGKme

This comment was marked as resolved.

@ShGKme
Copy link
Contributor

ShGKme commented Jan 8, 2026

@Antreesy Antreesy force-pushed the fix/deps/focus-trap branch from 83b1a6c to 38d8cc5 Compare January 9, 2026 09:12
@Antreesy Antreesy requested a review from ShGKme January 9, 2026 09:12
@Antreesy
Copy link
Contributor Author

Antreesy commented Jan 9, 2026

/backport! to stable8

@Antreesy Antreesy merged commit 4ed472e into main Jan 9, 2026
28 checks passed
@Antreesy Antreesy deleted the fix/deps/focus-trap branch January 9, 2026 11:36
@Antreesy Antreesy mentioned this pull request Jan 9, 2026
@ShGKme ShGKme modified the milestones: 9.4.0, 9.3.3 Jan 9, 2026
"escape-html": "^1.0.3",
"floating-vue": "^5.2.2",
"focus-trap": "^7.7.1",
"focus-trap": "7.6.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not

Suggested change
"focus-trap": "7.6.6",
"focus-trap": "~7.6.6",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was done with npm install --save-exact
Also by changelog history for focus-trap, I assume there are no plans to release patch versions for 7.6.x

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if there is 7.6.7, I'd not update automatically anyway

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no guarantee for new versions compatibility with older versions in the same stack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants