feat(app-api): add HaRP container #7493
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com> Signed-off-by: bigcat88 <bigcat88@icloud.com>
37 tasks
szaimen
reviewed
Jan 27, 2026
Collaborator
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR!
Looks already pretty good but some comments from my side below :)
| "NET_RAW" | ||
| ], | ||
| "backup_volumes": [ | ||
| "nextcloud_aio_harp" |
Collaborator
There was a problem hiding this comment.
How important are these certs? Cant they simply get recreated if they got missing or is this not possible?
|
|
||
| function handleDockerSocketProxyWarning() { | ||
| if (document.getElementById("docker-socket-proxy").checked) { | ||
| alert('⚠️ Warning! Enabling this container comes with possible Security problems since you are exposing the docker socket and all its privileges to the Nextcloud container. Enable this only if you are sure what you are doing!'); |
Collaborator
There was a problem hiding this comment.
Suggested change
| alert('⚠️ The docker socket proxy container is deprecated. Please use the HaRP (High-availability Reverse Proxy for Nextcloud ExApps) instead!'); | |
| document.getElementById("docker-socket-proxy").checked = false |
| { | ||
| "container_name": "nextcloud-aio-docker-socket-proxy", | ||
| "image_tag": "%AIO_CHANNEL%", | ||
| "display_name": "Docker Socket Proxy", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "display_name": "Docker Socket Proxy (deprecated)", |
| @@ -126,6 +126,20 @@ | |||
| > | |||
| <label for="docker-socket-proxy">Docker Socket Proxy (needed for <a target="_blank" href="https://github.com/cloud-py-api/app_api#nextcloud-appapi">Nextcloud App API</a>)</label> | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| <label for="docker-socket-proxy">Docker Socket Proxy (needed for <a target="_blank" href="https://github.com/cloud-py-api/app_api#nextcloud-appapi">Nextcloud App API</a>)</label> | |
| <label for="docker-socket-proxy">Docker Socket Proxy (needed for <a target="_blank" href="https://github.com/cloud-py-api/app_api#nextcloud-appapi">Nextcloud App API</a>) ⚠️ The docker socket proxy container is deprecated. Please use the HaRP (High-availability Reverse Proxy for Nextcloud ExApps) instead!</label> |
Collaborator
|
@oleksandr-nc please also increase the version number here: all-in-one/php/templates/containers.twig Line 30 in 9c6bb67 |
szaimen
reviewed
Jan 27, 2026
| data-initial-state="false" | ||
| {% endif %} | ||
| > | ||
| <label for="harp">HaRP (High-availability Reverse Proxy for <a target="_blank" href="https://github.com/nextcloud/HaRP">Nextcloud ExApps</a>)</label> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <label for="harp">HaRP (High-availability Reverse Proxy for <a target="_blank" href="https://github.com/nextcloud/HaRP">Nextcloud ExApps</a>)</label> | |
| <label for="harp">HaRP (High-availability Reverse Proxy for <a target="_blank" href="https://github.com/cloud-py-api/app_api#nextcloud-appapi">Nextcloud ExApps</a>)</label> |
Collaborator
|
There are unfortunately some conflicts now, so this needs a rebase |
24 tasks
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, we should first merge the PR into AppAPI (nextcloud/app_api#768) and then re-test this PR.
I tested this PR without automatic registration, from template; my HaRP was registered
okand TestDeploy worked.