Inject Session Time Out To The Remote Operation Constructors

[alperozturk96]

The client must be able to modify the session timeout according to their needs. For example, if the server instance slow, some network operations may fail. This could lead to issues, especially during end-to-end (E2E) operations.

Changes

SessionTimeOut data class has been added.
The default SessionTimeOut is utilized for each remote operation in the first constructor.
A second constructor has been added to allow custom SessionTimeOut injection for each remote operation.

How to Test?

Files client must build without any compile error
Files client must be able to configure SessionTimeOut for any remote operations

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[alperozturk96]

Failing test is unrelated. Example merged PR: #1593

[ZetaTom]

Overall, this seems to be working as expected. There are a few minor things that I would suggest changing, for which I've added some comments.

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[nextcloud-android-bot]

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3603-IT-stable-15-53/debug/

[alperozturk96]

@tobiasKaminsky @AndyScherzinger Can we merge this PR? Since unrelated tests are keep failing for previously merged PRs as well.

[ZetaTom]

Apart from the new default timeouts, everything looks fine. I haven't noticed any change in behaviour when running tests. However, we need to consider whether the new timeouts have any unintended consequences.

[alperozturk96]

I think increasing SYNC_READ_TIMEOUT and SYNC_CONNECTION_TIMEOUT values should not cause any issues, and it is straightforward changes.

However, if there’s a argument against this, it would be great to discuss it further. Any code modification can sometimes lead to unexpected behavior :)

[nextcloud-android-bot]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3616-IT-master-18-42/debug/

[nextcloud-android-bot]

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3616-IT-stable-18-44/debug/

[alperozturk96]

/backport to stable-2.19