Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Jan 7, 2025

Backport of PR #14161

Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@github-actions
Copy link

github-actions bot commented Jan 7, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14329.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Jan 7, 2025

Lint

Typestable-3.30PR
Warnings60136
Errors39

SpotBugs

CategoryBaseNew
Bad practice6363
Correctness6262
Dodgy code300300
Experimental11
Internationalization77
Multithreaded correctness77
Performance5353
Security1818
Total511511

Lint increased!

@github-actions
Copy link

github-actions bot commented Jan 7, 2025

Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please not yet merge as of #14198

@tobiasKaminsky
Copy link
Member

That is the risky PR, so we do not merge it.
@alperozturk96 you wanted to create a fix for the master branch, right?

@alperozturk96
Copy link
Collaborator

alperozturk96 commented Jan 13, 2025

That is the risky PR, so we do not merge it. @alperozturk96 you wanted to create a fix for the master branch, right?

This PR fixes the both problem

@alperozturk96 alperozturk96 removed this from the Nextcloud App 3.30.8 milestone Jan 13, 2025
@tobiasKaminsky tobiasKaminsky deleted the backport/14161/stable-3.30 branch February 25, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants