fix: eTag comparison

[alperozturk96]

• Tests written, or not not needed

Previous logic before metadata worker implementation:

mRemoteFolderChanged = !(remoteFolderETag.equalsIgnoreCase(localFolderEtag));

private RemoteOperationResult checkForChanges(OwnCloudClient client) {
        mRemoteFolderChanged = true;
        RemoteOperationResult result;
        String remotePath = mLocalFolder.getRemotePath();

        Log_OC.d(TAG, "Checking changes in " + user.getAccountName() + remotePath);

        // remote request
        result = new ReadFileRemoteOperation(remotePath).execute(client);

        if (result.isSuccess()) {
            if (!mIgnoreETag && result.getData().get(0) instanceof RemoteFile remoteFile) {
                // check if remote and local folder are different
                String remoteFolderETag = remoteFile.getEtag();
                if (remoteFolderETag != null) {
                    String localFolderEtag = mLocalFolder.getEtag();
                    mRemoteFolderChanged = !(remoteFolderETag.equalsIgnoreCase(localFolderEtag));
                    Log_OC.d(
                        TAG,
                        "📂 eTag check\n" +
                            "  Path:        " + remoteFile.getRemotePath() + "\n" +
                            "  Local eTag:  " + localFolderEtag + "\n" +
                            "  Remote eTag: " + remoteFolderETag + "\n" +
                            "  Changed:     " + mRemoteFolderChanged
                            );
                } else {
                    Log_OC.e(TAG, "Checked " + user.getAccountName() + remotePath + ": No ETag received from server");
                }
            } else {
                Log_OC.d(TAG, "Ignoring eTag. mRemoteFolderChanged is true.");
            }

            result = new RemoteOperationResult(ResultCode.OK);

            Log_OC.i(TAG, "Checked " + user.getAccountName() + remotePath + " : " +
                (mRemoteFolderChanged ? "changed" : "not changed"));

        } else {
            // check failed
            if (result.getCode() == ResultCode.FILE_NOT_FOUND) {
                removeLocalFolder();
            }
            if (result.isException()) {
                Log_OC.e(TAG, "Checked " + user.getAccountName() + remotePath + " : " +
                    result.getLogMessage(), result.getException());
            } else {
                Log_OC.e(TAG, "Checked " + user.getAccountName() + remotePath + " : " +
                    result.getLogMessage());
            }
        }

        return result;
    }

[alperozturk96]

/backport to stable-3.35

[alperozturk96]

Don't remove spaces and compare just like before.

[alperozturk96]

If even spaces are same and content is same we can consider as eTag didnt change

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16164.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	43	43
Correctness	73	73
Dodgy code	257	257
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	3	3
Multithreaded correctness	34	34
Performance	43	43
Security	18	18
Total	479	479

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.