fix: register/unregister broadcast receivers #16165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alperozturk <[email protected]>
alperozturk96
requested review from
AndyScherzinger,
ZetaTom and
tobiasKaminsky
Collaborator
Author
|
/backport to stable-3.35 |
1 task
alperozturk96
commented
Dec 18, 2025
| val fileDisplayActivity = activity as FileDisplayActivity | ||
| fileDisplayActivity.updateActionBarTitleAndHomeButtonByString(getString(R.string.drawer_item_shared)) | ||
| fileDisplayActivity.setMainFabVisible(false) | ||
| fileDisplayActivity.initSyncBroadcastReceiver() |
Collaborator
Author
There was a problem hiding this comment.
No need to register from here again since SharedListFragment child of OCFileListFragment and OCFileListFragment used in FileDisplayActivity.
ZetaTom
requested changes
Dec 18, 2025
app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom <[email protected]> Signed-off-by: Alper Öztürk <[email protected]>
ZetaTom
approved these changes
Dec 18, 2025
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16165.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When the user navigates to a subdirectory from the Favorites or Shared tab, the receivers are unregistered, which causes the folder to not refresh correctly.
Changes
Receivers needs to be registered and unregistered on onStart/onStop.
Documentation:
Result