fix(docker-registry-override): change NcButton to NcActionButton #745
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksander Piskun <[email protected]>
julien-nc
approved these changes
Jan 13, 2026
Member
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Nice catch. It was mentioned in the vue3 migration guide i wrote 😅 :
The action template now only accepts/displays components which name starts with NcAction*.
So it was a potential bug in the initial implementation 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, while developing, I accidentally discovered that the existing "remove registry override" action is now missing from the UI.
As a remeber, there definitely was previously an option to remove a registry override.
This was likely broken during the migration to Vue 3 in pull request #705.
Before commit:
After commit: