feat: serialize namespaced attributes consistently across browsers #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously generated XML was valid, but the generated namespace IDs for namespaces of attributes differed between different browsers.
For example, the following code produces different results in different browsers:
```javascript
XMLUtility.serialize({
name: ['myNs1', 'element'],
attributes: [['myNs2', 'abc', '123']]
}
```
In Chrome it generated `<x0:element xmlns:x0="myNs1" xmlns:ns1="myNs2" ns1:abc="123"/>`.
And in Firefox it generated `<x0:element xmlns:x0="myNs1" a0:abc="123" xmlns:a0="myNs2"/>`.
One used the prefix `ns1` and the other used `a0`.
Signed-off-by: Oleksandr Dzhychko <[email protected]>
Running test with Chromium and WebKit surfaced non-breaking inconsistencies in XML serialization. They might catch other issues in the future. Signed-off-by: Oleksandr Dzhychko <[email protected]>
st3iny
approved these changes
Mar 31, 2025
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
Looks good, thanks a lot.
I amended the commit to replace spaces with tabs.
st3iny
added
enhancement
odzhychko
deleted the
serialize-attribute-prefixes-consistently-across-browsers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed two inconsistencies in XML serialization between different browsers.
The first I fixed in a10ba02.
The other I just documented after configuring tests to run with different browsers in f716398.
Feel free to apply these changes if you find them useful.
Or just close this PR when you don't need them.