fix(dashboard): Add icon-teams CSS class and fix path to app icon#1520
Merged
juliusknorr merged 1 commit intomasterfrom Mar 6, 2024
Merged
fix(dashboard): Add icon-teams CSS class and fix path to app icon#1520juliusknorr merged 1 commit intomasterfrom
icon-teams CSS class and fix path to app icon#1520juliusknorr merged 1 commit intomasterfrom
Conversation
juliusknorr
reviewed
Mar 5, 2024
juliusknorr
reviewed
Mar 5, 2024
juliusknorr
reviewed
Mar 5, 2024
Member
|
Just looked into moving over files_sharing, which would actually also have the class defined now in core: nextcloud/server#44007 maybe we can then skip loading an additional css file |
Signed-off-by: Jonas <jonas@freesources.org>
skjnldsv
approved these changes
Mar 6, 2024
juliusknorr
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the path to the app icon fixes dashboard widgets. Otherwise getting the widgets throws an error and all widgets are broken.
Adding the
icon-teamsCSS class fixes displaying the teams icon in the teams dashboard widget.