feat: Emit UserShareAccessUpdatedEvent #2289
Draft
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <[email protected]>
ArtificialOwl
approved these changes
Jan 15, 2026
Member
ArtificialOwl
left a comment
ArtificialOwl
left a comment
There was a problem hiding this comment.
listening on CircleMemberAddedEvent and CircleMemberRemovedEvent might be better
Member
Author
|
Needs adjustment for nextcloud/server#57564 |
provokateurin
commented
Jan 15, 2026
| foreach ($circle->getInheritedMembers() as $inheritedMember) { | ||
| // TODO: Send event for all members at once | ||
| // We already iterate the inherited members, so we don't need to recurse the member circles again | ||
| $this->emitShareAccessUpdateEvent($inheritedMember, ignoreCircles: true); |
Member
Author
There was a problem hiding this comment.
Instead of recursing this should just emit the events directly for Member::TYPE_USER (as users in groups are already expanded).
Member
|
I'm not seeing any sign of the event being emitted in my testing. Either adding or removing a user from a circle doesn't trigger the event listener |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.