use_branding patch #23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Schuster <[email protected]> Signed-off-by: dogwolf <[email protected]>
…rst launch Ensure that the config variable 'showInExplorerNavigationPane' reflects the user's choice and write it to the nextcloud.cfg file. Signed-off-by: Michael Schuster <[email protected]> Signed-off-by: dogwolf <[email protected]>
Signed-off-by: Michael Schuster <[email protected]> Signed-off-by: dogwolf <[email protected]>
Rename nextcloud to the app_name parameter Signed-off-by: dogwolf <[email protected]>
Rename nextcloud to app_name parameter Signed-off-by: dogwolf <[email protected]>
Fixed nextcloudsync.dll name otherwise executable returns an error Signed-off-by: dogwolf <[email protected]>
Signed-off-by: dogwolf <[email protected]>
Signed-off-by: dogwolf <[email protected]>
Signed-off-by: dogwolf <[email protected]>
Signed-off-by: dogwolf <[email protected]>
Contributor
Author
|
Hello, |
|
Right now you have also commits other than yours, @dogwolf could you please create a separate branch based off of master with only your commits and update this MergeRequest? |
Contributor
Author
|
Sorry to reply so late, but I'm not used to work with branches. Thank you |
|
Thank you this one can be closed in favor of #30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patch is related to the issue #4
If you set USE_BRANDING = 1 the building process cannot finish because of this line
start "windeployqt" /B /wait windeployqt.exe --%WINDEPLOYQT_BUILD_TYPE% --compiler-runtime "%MY_INSTALL_PATH%/bin/%APP_NAME%.exe" --dir "%MY_QT_DEPLOYMENT_PATH%/"
This %APP_NAME%.exe is not found.
The pull request rename files and directories after the compilation process. The main disadvantage is
nextcloud.cfg and nextcloudsync.dll cannot be rebranded otherwise the nextcloud.exe (the new one rebranded) cannot find the dll and cfg