Skip to content

refactor(settings): reorganize settings dialog with new form components #4865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nfebe merged 1 commit into from
Nov 17, 2025
Merged

refactor(settings): reorganize settings dialog with new form components #4865

nfebe merged 1 commit into from
Nov 17, 2025

Conversation

@nfebe
Copy link
Contributor

@nfebe nfebe commented Nov 17, 2025 •
edited
Loading

Use NcFormBox, NcFormBoxSwitch, and related components to modernize the settings dialog layout following the new design patterns.

Screenshots

NOW

Address book inactive Address book active
contact-settings-address-book-inacttive contact-settings-address-book-activ

EARLIER

contacts-before

Resolves : #4785

@nfebe nfebe added 3. to review Waiting for reviews feature: contacts labels Nov 17, 2025
@nfebe
Copy link
Contributor Author

nfebe commented Nov 17, 2025

Just realized this a duplicate of : #4803

@GVodyanov ps kindly let me know if it okay for this to proceed or you will finish the existing work.

nfebe
nfebe commented Nov 17, 2025
View reviewed changes
Copy link
Contributor Author

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kra-mo for the first element it is not possible to fufill the design using the library for the moment as the element NcFormBoxSelectNative is not yet merged: nextcloud-libraries/nextcloud-vue#7838

If it is an asbolute must the way forward is to copy the element code and use like a custom element every where it is needed but with a comment to remove when the library has it. (Inside the component file and everywhere it is used)

@nfebe nfebe force-pushed the refactor/4785/contact-settings-reorganization branch from 7639795 to 1612d69 Compare November 17, 2025 18:23
@codecov
Copy link

codecov bot commented Nov 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../AppNavigation/Settings/SettingsNewAddressbook.vue 0.00% 26 Missing ⚠️
src/components/AppNavigation/ContactsSettings.vue 0.00% 9 Missing ⚠️
...ts/AppNavigation/Settings/SettingsSortContacts.vue 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@nfebe nfebe force-pushed the refactor/4785/contact-settings-reorganization branch from 1612d69 to c29a283 Compare November 17, 2025 18:34
GVodyanov
GVodyanov reviewed Nov 17, 2025
View reviewed changes
GVodyanov
GVodyanov reviewed Nov 17, 2025
View reviewed changes
@nfebe @GVodyanov
refactor(settings): reorganize settings dialog with new form components
59a0ba9 
Use NcFormBox, NcFormBoxSwitch, and related components to modernize
the settings dialog layout following the new design patterns.

- Replace CheckboxRadioSwitch with NcFormBoxSwitch for social sync
- Wrap sort select in NcFormBox for consistent styling
- Convert new address book to button with expandable form
- Update address book list styling with borders and proper spacing
- Add success/error toast notifications for setting changes
- Bump @nextcloud/vue to ^9.2.0 for NcFormBox components

Signed-off-by: nfebe <[email protected]>
@GVodyanov GVodyanov force-pushed the refactor/4785/contact-settings-reorganization branch from b883cc6 to 59a0ba9 Compare November 17, 2025 22:07
GVodyanov
GVodyanov approved these changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@GVodyanov GVodyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking really good!

(I just made a few small changes to match all of the details of the design spec)

@GVodyanov GVodyanov requested a review from kra-mo November 17, 2025 22:09
@GVodyanov GVodyanov mentioned this pull request Nov 17, 2025
Closed
@nfebe nfebe merged commit c74aee9 into main Nov 17, 2025
42 of 43 checks passed
@nfebe nfebe deleted the refactor/4785/contact-settings-reorganization branch November 17, 2025 22:10
@AndyScherzinger
Copy link
Member

AndyScherzinger commented Nov 18, 2025

I guess this needs a backport for shipping on v32 of the server or is the main branch targeting v32? @GVodyanov @nfebe @ChristophWurst

@GVodyanov
Copy link
Contributor

GVodyanov commented Nov 18, 2025

/backport to stable8.1

@backportbot backportbot bot mentioned this pull request Nov 18, 2025
Merged
@GVodyanov
Copy link
Contributor

GVodyanov commented Nov 18, 2025

/backport to stable8.0

@backportbot backportbot bot mentioned this pull request Nov 18, 2025
Closed
2 tasks
@kesselb kesselb mentioned this pull request Nov 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GVodyanov GVodyanov GVodyanov approved these changes

@hamza221 hamza221 Awaiting requested review from hamza221 hamza221 is a code owner

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner

@kra-mo kra-mo Awaiting requested review from kra-mo

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: contacts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Contacts settings reorganization

4 participants

@nfebe @AndyScherzinger @GVodyanov