Skip to content

Conversation

@max65482
Copy link
Contributor

@max65482 max65482 commented Jan 4, 2026

Fixes #4538
image

@hamza221 hamza221 added enhancement New feature or request 3. to review Waiting for reviews labels Jan 5, 2026
Copy link
Contributor

@hamza221 hamza221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the Pr,
It looks good to me aside from one point,
On creating a new contact I would expect Cancel to cancel the creation of the contact aka delete the contact.
Maybe we should not show the button for contacts that are just created ? what do you think ?

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/ContactDetails.vue 0.00% 10 Missing ⚠️
src/store/contacts.js 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@max65482
Copy link
Contributor Author

max65482 commented Jan 5, 2026

I agree that the cancel button could be misunderstood when editing newly created contacts. I removed it in this case.

hamza221

This comment was marked as duplicate.

Copy link
Contributor

@hamza221 hamza221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from a couple questions

@hamza221 hamza221 force-pushed the feat/cancel-contact-editing branch from f82b0a1 to a2d4b5e Compare January 13, 2026 10:34
@hamza221
Copy link
Contributor

I only squashed the commits

@hamza221 hamza221 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 13, 2026
@hamza221 hamza221 merged commit 9991512 into nextcloud:main Jan 13, 2026
43 of 44 checks passed
@welcome
Copy link

welcome bot commented Jan 13, 2026

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@max65482
Copy link
Contributor Author

@hamza221 Thanks for reviewing an merging! Should this be backported?

@hamza221
Copy link
Contributor

hamza221 commented Jan 13, 2026

@hamza221 Thanks for reviewing an merging! Should this be backported?

We usually don't backport features, but good news this is already pre-released v8.3.0-rc.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing cancel button when editing

2 participants