Skip to content

fix: cypress issue#6778

Merged
luka-nextcloud merged 1 commit intomainfrom
fix-cypress-main
Feb 21, 2025
Merged

fix: cypress issue#6778
luka-nextcloud merged 1 commit intomainfrom
fix-cypress-main

Conversation

@luka-nextcloud
Copy link
Copy Markdown
Contributor

  • Resolves: #
  • Target version: main

Summary

Fixes cypress issue in the workflow.

Signed-off-by: Luka Trovic <luka@nextcloud.com>
Copy link
Copy Markdown
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good if the action from line 80 would also change the URL so that a reload indeed works. Not sure whether this might be a cypress limitation? That would be favorable, also from UX wise. Otherwise OK.

@luka-nextcloud
Copy link
Copy Markdown
Contributor Author

It would be good if the action from line 80 would also change the URL so that a reload indeed works. Not sure whether this might be a cypress limitation? That would be favorable, also from UX wise. Otherwise OK.

I don't understand what you mean. Line 78 to 88 is actions on modal. Why should they change the URL?

@blizzz
Copy link
Copy Markdown
Member

blizzz commented Feb 20, 2025

It would be good if the action from line 80 would also change the URL so that a reload indeed works. Not sure whether this might be a cypress limitation? That would be favorable, also from UX wise. Otherwise OK.

I don't understand what you mean. Line 78 to 88 is actions on modal. Why should they change the URL?

Screenshot_20250220_183356

is what I mean, i hope it is more clear?

@luka-nextcloud
Copy link
Copy Markdown
Contributor Author

@blizzz So, this is a suggestion for a behavior update of the create card modal. If we implement this, after a card is created, the user will stay on the selected board page. I'm not sure if this would be a better UX. I think some users might prefer to stay on the overview page to create cards for multiple boards and check the overview more easily.

@luka-nextcloud luka-nextcloud merged commit 439e441 into main Feb 21, 2025
31 checks passed
@luka-nextcloud luka-nextcloud deleted the fix-cypress-main branch February 21, 2025 09:58
@blizzz
Copy link
Copy Markdown
Member

blizzz commented Feb 21, 2025

@blizzz So, this is a suggestion for a behavior update of the create card modal. If we implement this, after a card is created, the user will stay on the selected board page. I'm not sure if this would be a better UX. I think some users might prefer to stay on the overview page to create cards for multiple boards and check the overview more easily.

Now, than that's fine!

@luka-nextcloud
Copy link
Copy Markdown
Contributor Author

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants