Skip to content

Clear selected stack when selected board changed#6902

Merged
luka-nextcloud merged 1 commit intomainfrom
update-card-move-dialog
Apr 15, 2025
Merged

Clear selected stack when selected board changed#6902
luka-nextcloud merged 1 commit intomainfrom
update-card-move-dialog

Conversation

@luka-nextcloud
Copy link
Copy Markdown
Contributor

@luka-nextcloud luka-nextcloud commented Apr 11, 2025

Summary

In the "Move/Copy Card" dialog, the selected stack should be cleared upon changing the selected board. This enhancement prevents confusion when multiple boards have stacks with identical names, which could lead to incorrect stack selection and card was not moved correctly.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included

@luka-nextcloud luka-nextcloud changed the title fix: clear selected stack when selected board changed Clear selected stack when selected board changed Apr 11, 2025
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Apr 11, 2025
@luka-nextcloud luka-nextcloud moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Apr 11, 2025
Copy link
Copy Markdown
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible, but the Cypress test failure does seem related. The "Copy card" button is disabled now so the click() doesn't go through

Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud luka-nextcloud force-pushed the update-card-move-dialog branch from f1a23e3 to 6dbcf5d Compare April 14, 2025 18:29
@luka-nextcloud luka-nextcloud requested a review from elzody April 14, 2025 18:30
@luka-nextcloud luka-nextcloud merged commit 1cd6c55 into main Apr 15, 2025
32 checks passed
@luka-nextcloud luka-nextcloud deleted the update-card-move-dialog branch April 15, 2025 16:33
@github-project-automation github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Apr 15, 2025
@luka-nextcloud
Copy link
Copy Markdown
Contributor Author

/backport to stable29

@luka-nextcloud
Copy link
Copy Markdown
Contributor Author

/backport to stable30

@luka-nextcloud
Copy link
Copy Markdown
Contributor Author

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Clear Selected Stack When Changing Boards in "Move/Copy Card" Dialog

2 participants