Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
a44388d to
68f00be
Compare
|
🐢 Performance warning. |
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
68f00be to
711373e
Compare
grnd-alt
left a comment
There was a problem hiding this comment.
one improvement that would be nice for ux, otherwise works well 🔥
| } else if (this.board.settings['notify-due'] === 'off') { | ||
| return 'icon-sound-off' | ||
| } | ||
| return '' |
There was a problem hiding this comment.
I wouldn't remove that code, we can still show the correct icon (same for the text).
You can use the @update:menuOpen hook on the NcAppNavigationItem in line 16, so when the menu is opened you can load the settings. I think that's the best option because then we don't show an icon only until the board is loaded and then have the correct one displayed.
There was a problem hiding this comment.
Gotcha, should be ok now?
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Summary
Screencast.Fix.mp4