Skip to content

Fix missing due date remember icons#7626

Open
theoholl wants to merge 6 commits intomainfrom
7511-missing-icons-on-shared-boards-dropdown
Open

Fix missing due date remember icons#7626
theoholl wants to merge 6 commits intomainfrom
7511-missing-icons-on-shared-boards-dropdown

Conversation

@theoholl
Copy link
Copy Markdown
Contributor

@theoholl theoholl commented Feb 8, 2026

Summary

  • Update the three-dot menu to contain a regular 'Due date reminder' item with an icon
  • Load due date reminder settings lazily
Screencast.Fix.mp4

@theoholl theoholl linked an issue Feb 8, 2026 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@theoholl theoholl force-pushed the 7511-missing-icons-on-shared-boards-dropdown branch from a44388d to 68f00be Compare March 4, 2026 13:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 4, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84616 was 84323 (+0.34%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
@theoholl theoholl force-pushed the 7511-missing-icons-on-shared-boards-dropdown branch from 68f00be to 711373e Compare March 12, 2026 19:34
@theoholl theoholl marked this pull request as ready for review March 12, 2026 19:39
Copy link
Copy Markdown
Member

@grnd-alt grnd-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one improvement that would be nice for ux, otherwise works well 🔥

} else if (this.board.settings['notify-due'] === 'off') {
return 'icon-sound-off'
}
return ''
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't remove that code, we can still show the correct icon (same for the text).
You can use the @update:menuOpen hook on the NcAppNavigationItem in line 16, so when the menu is opened you can load the settings. I think that's the best option because then we don't show an icon only until the board is loaded and then have the correct one displayed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, should be ok now?

Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
@theoholl theoholl requested a review from grnd-alt March 19, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing icons on shared boards dropdown

2 participants