fix(macOS): hide dock icon when closing settings with ⌘+W

The ⌘+W shortcut was connected to QDialog::accept(), which internally
calls hide() and emits QEvent::Hide. The ForegroundBackground event
filter only listens for QEvent::Close, so the dock icon remained visible.

Clicking the window's close button works correctly because it sends
QEvent::Close directly.

Connecting the shortcut to close() instead of accept() ensures
QEvent::Close is sent, making ⌘+W behave identically to the close
button: the event filter fires, ToBackground() is called, and the dock
icon disappears.

Signed-off-by: Iva Horn <iva.horn@nextcloud.com>

Author: i2h3

src/gui/settingsdialog.cpp

@@ -153,7 +153,7 @@ SettingsDialog::SettingsDialog(ownCloudGui *gui, QWidget *parent)
     // People perceive this as a Window, so also make Ctrl+W work
     auto *closeWindowAction = new QAction(this);
     closeWindowAction->setShortcut(QKeySequence("Ctrl+W"));
-    connect(closeWindowAction, &QAction::triggered, this, &SettingsDialog::accept);
+    connect(closeWindowAction, &QAction::triggered, this, &SettingsDialog::close);
     addAction(closeWindowAction);
 
     setObjectName("Settings"); // required as group for saveGeometry call