modify AppImage build script to work with an EL8 base#7782
Conversation
mgallien
left a comment
mgallien
left a comment
There was a problem hiding this comment.
can you also change the appimage image tag to get it to build with it ?
https://github.com/nextcloud/docker-ci/pkgs/container/continuous-integration-client-appimage-qt6/342014829?tag=client-appimage-el8-6.8.1-1
nilsding
force-pushed
the
feature/client-alma8
branch
2 times, most recently
from
380338d to
34813d3
Compare
|
AppImage file: nextcloud-PR-7782-34813d3ec0782ee5e65bca79c25df6d7d17c703b-x86_64.AppImage |
mgallien
left a comment
mgallien
left a comment
There was a problem hiding this comment.
you also need to modify .drone.yml
https://github.com/nextcloud/desktop/blob/master/.drone.yml#L155
nilsding
force-pushed
the
feature/client-alma8
branch
from
5b57ca6 to
1cef01f
Compare
|
cool, the comment deletion works :D |
nilsding
force-pushed
the
feature/client-alma8
branch
from
2f2b06e to
7c16a81
Compare
mgallien
left a comment
mgallien
left a comment
There was a problem hiding this comment.
see my inline comments
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
.cache is used by clangd on my setup; built AppImages also shouldn't be part of the repo Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
see https://github.com/nextcloud/docker-ci/pkgs/container/continuous-integration-client-appimage-qt6/342431972?tag=client-appimage-el8-6.8.1-2 Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
feature/client-alma8
branch
from
bc46592 to
9340a2e
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-7782.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
3 participants
these changes are needed to make AppImage builds work with the new Alma8-based image from nextcloud/docker-ci#710