Check for existence of a directory to remove before attempting to do so #9288
Conversation
… attempting to do so. Signed-off-by: Iva Horn <[email protected]>
i2h3
requested review from
Aiiaiiio,
camilasan,
mgallien and
nilsding
as code owners
i2h3
changed the title
i2h3
added
bug
os: 🍎 macOS
CI build/checks
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 💻 Desktop Clients team
i2h3
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 💻 Desktop Clients team
There was a problem hiding this comment.
Pull request overview
This PR improves the robustness of the build process by checking for the existence of the client build directory before attempting to remove it during a full rebuild. This prevents potential errors when the directory doesn't exist.
Key changes:
- Added
fileExists(atPath:)check before attempting to remove the client build directory - Added informative logging when the directory is being removed
- Simplified error handling to focus on the removal failure
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Artifact containing the AppImage: nextcloud-appimage-pr-9288.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 💻 Desktop Clients team
Fixes our CI, too.