Handle macOS alias files in File Provider Extension#9445
Merged
Conversation
i2h3
added
the
feature: 📁 file provider
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 💻 Desktop Clients team
i2h3
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 💻 Desktop Clients team
i2h3
force-pushed
the
i2h3/fix/8436-aliases
branch
from
d32153c to
833dac2
Compare
i2h3
force-pushed
the
i2h3/fix/8436-aliases
branch
2 times, most recently
from
ef42c6a to
4b14466
Compare
i2h3
requested review from
Aiiaiiio,
camilasan,
mgallien and
nilsding
as code owners
i2h3
changed the title
i2h3
changed the title
Collaborator
Author
|
/backport to stable-33.0 |
i2h3
force-pushed
the
i2h3/fix/8436-aliases
branch
from
4b14466 to
c9fb165
Compare
…or extension (fixes #8436) macOS alias files have no MIME type and no file extension, so their type cannot be inferred from server metadata alone during enumeration. On upload, preserve the `com.apple.alias-file` UTI in stored metadata instead of falling back to an empty string when no MIME type is available. On download, detect alias files by reading the Apple Bookmark magic bytes ("book", 0x62 0x6F 0x6F 0x6B) from the fetched file content. When found, update the stored metadata with the correct content type so the File Provider framework handles the file as an alias rather than opaque binary data. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
i2h3
force-pushed
the
i2h3/fix/8436-aliases
branch
from
c9fb165 to
22dbedb
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9445.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 💻 Desktop Clients team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our file provider extension reports back
public.contentas the fallback content type for items it cannot find a MIME type for by using UniformTypeIdentifiers framework.macOS alias files do not have a standardized MIME type because they are specific to macOS. Hence our extension stores an empty string. In the conversion back to a
FileProviderItemProtocolobject a fallback switch returnscontent, even though it should have beenaliasFile.This closes #8436.