Skip to content

fix(propagateuploadng): do not encode davUrl #9588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nilsding merged 1 commit into from
Mar 11, 2026

fix(propagateuploadng): do not encode davUrl

0214fc7
Select commit
Loading
Failed to load commit list.
Merged

fix(propagateuploadng): do not encode davUrl #9588

fix(propagateuploadng): do not encode davUrl
0214fc7
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 11, 2026 in 32m 39s

Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
10 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 415 in src/libsync/propagateuploadng.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this declaration by a structured binding declaration. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzXRP25JBdaFffnDtFP&open=AZzXRP25JBdaFffnDtFP&pullRequest=9588

Check warning on line 183 in src/libsync/propagateuploadng.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a local variable "job" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzXRP25JBdaFffnDtFL&open=AZzXRP25JBdaFffnDtFL&pullRequest=9588

Check warning on line 503 in src/libsync/propagateuploadng.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this declaration by a structured binding declaration. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzXRP25JBdaFffnDtFR&open=AZzXRP25JBdaFffnDtFR&pullRequest=9588

Check failure on line 165 in src/libsync/propagateuploadng.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzXRP25JBdaFffnDtFM&open=AZzXRP25JBdaFffnDtFM&pullRequest=9588

Check failure on line 183 in src/libsync/propagateuploadng.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzXRP25JBdaFffnDtFO&open=AZzXRP25JBdaFffnDtFO&pullRequest=9588

Check warning on line 359 in src/libsync/propagateuploadng.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "isLocked" of type "_Bool" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzdtX6fqn45uAgxgHJR&open=AZzdtX6fqn45uAgxgHJR&pullRequest=9588

Check warning on line 183 in src/libsync/propagateuploadng.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "job" of type "class OCC::DeleteJob *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzXRP25JBdaFffnDtFN&open=AZzXRP25JBdaFffnDtFN&pullRequest=9588

Check warning on line 539 in src/libsync/propagateuploadng.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this "if" statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzXRP25JBdaFffnDtFQ&open=AZzXRP25JBdaFffnDtFQ&pullRequest=9588

Check failure on line 118 in src/libsync/propagateuploadng.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzXRP25JBdaFffnDtFK&open=AZzXRP25JBdaFffnDtFK&pullRequest=9588

Check failure on line 102 in src/libsync/propagateuploadng.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzXRP25JBdaFffnDtFJ&open=AZzXRP25JBdaFffnDtFJ&pullRequest=9588
View more details on SonarQubeCloud