fix(settings): add missing endGroup() in Folder::removeFromSettings#9607
Open
agners wants to merge 1 commit intonextcloud:masterfrom
Open
fix(settings): add missing endGroup() in Folder::removeFromSettings#9607agners wants to merge 1 commit intonextcloud:masterfrom
agners wants to merge 1 commit intonextcloud:masterfrom
Conversation
agners
requested review from
Aiiaiiio,
camilasan,
i2h3,
mgallien and
nilsding
as code owners
The last beginGroup("FoldersWithPlaceholders") call was never closed
with endGroup(), leaving the QSettings group stack unbalanced.
Signed-off-by: Stefan Agner <stefan@agner.ch>
agners
force-pushed
the
bugfix/missing-endgroup-removeFromSettings
branch
from
60b4fd1 to
c8b2340
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9607.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Contributor
Author
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last beginGroup("FoldersWithPlaceholders") call was never closed with endGroup(), leaving the QSettings group stack dirty.