Skip to content

[stable-33.0] Refine new settings dialog#9616

Merged
mgallien merged 8 commits intostable-33.0from
backport/9599/stable-33.0
Mar 12, 2026
Merged

[stable-33.0] Refine new settings dialog#9616
mgallien merged 8 commits intostable-33.0from
backport/9599/stable-33.0

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Mar 12, 2026

Backport of PR #9599

…t in the stack

The wrapping QWidget would just assume the biggest size of any previous
widget and never get smaller.  As we can just™ set the scroll view's
widget to be the stackwidget it's unnecessary anyway

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
It was kinda empty and the widgets were created in the C++ code anyway.

Also makes the left account navigation toolbar scrollable through a scrollbar :)

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
let it grow, there's a parent widget anyway

small refactoring too: .ui now has a QVBoxLayout as its base instead of
a QGridLayout

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
… style

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
the padding is different between QWidget and QML style

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@backportbot backportbot bot requested a review from Rello March 12, 2026 14:20
@backportbot backportbot bot requested review from mgallien and nilsding as code owners March 12, 2026 14:20
@backportbot backportbot bot added this to the 33.0.0 milestone Mar 12, 2026
@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-9616.zip

Digest: sha256:d0045e27bf55ee56d53dc1f9061910364c30b380353e23fe9ca26b3592679787

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 9fa80c1 into stable-33.0 Mar 12, 2026
17 checks passed
@mgallien mgallien deleted the backport/9599/stable-33.0 branch March 12, 2026 14:36
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1.7% Coverage on New Code (required ≥ 80%)
13 New Code Smells (required ≤ 0)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants