Skip to content

Improve integration. #9617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgallien merged 3 commits into from
Mar 12, 2026
+41 −74

refactor(integration): remove MouseArea from ItemDelegate.

2116ce5
Select commit
Loading
Failed to load commit list.
Merged

Improve integration. #9617

refactor(integration): remove MouseArea from ItemDelegate.
2116ce5
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 12, 2026 in 19m 34s

Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
13 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 56 in src/gui/integration/fileactionsmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'qsizetype' (aka 'long long') to 'int' 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzitiS8Sd2Wf1VcF2D_&open=AZzitiS8Sd2Wf1VcF2D_&pullRequest=9617

Check warning on line 78 in src/gui/integration/fileactionsmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "accountState" of type "class OCC::AccountState *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzitiS8Sd2Wf1VcF2EC&open=AZzitiS8Sd2Wf1VcF2EC&pullRequest=9617

Check warning on line 341 in src/gui/integration/fileactionsmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "job" of type "class OCC::JsonApiJob *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzitiS8Sd2Wf1VcF2EH&open=AZzitiS8Sd2Wf1VcF2EH&pullRequest=9617

Check warning on line 187 in src/gui/integration/fileactionsmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "mimeDb" of type "class QMimeDatabase" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzitiS8Sd2Wf1VcF2EE&open=AZzitiS8Sd2Wf1VcF2EE&pullRequest=9617

Check warning on line 19 in src/gui/integration/fileactionsmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "parent" of type "class QObject *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzitiS8Sd2Wf1VcF2EA&open=AZzitiS8Sd2Wf1VcF2EA&pullRequest=9617

Check warning on line 4 in src/gui/integration/fileactionsmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzitiS8Sd2Wf1VcF2D-&open=AZzitiS8Sd2Wf1VcF2D-&pullRequest=9617

Check warning on line 288 in src/gui/integration/fileactionsmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid this unnecessary copy by using a "const" reference. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzitiS8Sd2Wf1VcF2EG&open=AZzitiS8Sd2Wf1VcF2EG&pullRequest=9617

Check warning on line 355 in src/gui/integration/fileactionsmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "statusCode" of type "int" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzitiS8Sd2Wf1VcF2EK&open=AZzitiS8Sd2Wf1VcF2EK&pullRequest=9617

Check warning on line 287 in src/gui/integration/fileactionsmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "end" of type "class QMap<class QString, class QVariant>::const_iterator" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzitiS8Sd2Wf1VcF2EF&open=AZzitiS8Sd2Wf1VcF2EF&pullRequest=9617

Check warning on line 166 in src/gui/integration/fileactionsmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "folderForPath" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzitiS8Sd2Wf1VcF2ED&open=AZzitiS8Sd2Wf1VcF2ED&pullRequest=9617

Check warning on line 24 in src/gui/integration/fileactionsmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "role" of type "int" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzitiS8Sd2Wf1VcF2EB&open=AZzitiS8Sd2Wf1VcF2EB&pullRequest=9617

Check failure on line 339 in src/gui/integration/fileactionsmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzitiS8Sd2Wf1VcF2EI&open=AZzitiS8Sd2Wf1VcF2EI&pullRequest=9617

Check warning on line 426 in src/gui/integration/fileactionsmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a local variable "row" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZzitiS8Sd2Wf1VcF2EJ&open=AZzitiS8Sd2Wf1VcF2EJ&pullRequest=9617
View more details on SonarQubeCloud