fix(asyncimageresponse): enhance check for received SVG response #9697
Merged
fix(asyncimageresponse): enhance check for received SVG response #9697
Conversation
nilsding
requested review from
Aiiaiiio,
camilasan,
i2h3 and
mgallien
as code owners
nilsding
added
bug
Prio: high
feature: ☁️ GUI
Member
Author
|
/backport to stable-33.0 |
nilsding
force-pushed
the
bugfix/9685/appicon-request
branch
2 times, most recently
from
fc978c7 to
6829d5d
Compare
mgallien
approved these changes
Mar 26, 2026
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Some SVG files do not start with `<svg`, but with `<?xml` and could include some additional metadata (e.g. a generator comment or licence header ...) Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
this may cause an infinite re-request loop if the layout does not match Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
mgallien
force-pushed
the
bugfix/9685/appicon-request
branch
from
6829d5d to
4b852e4
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9697.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some app icon SVGs do not start with
<svgbut with e.g.<?xmland could include some additional metadata (e.g. a generator comment or licence header ...) before the expected<svgtag ... therefore let's check whether the reply is an SVG by peeking at the content-type header and the first 512 bytes of the response if the header was not enough.Resolves #9685, resolves #9689, resolves #9681.
fix confirmed on Windows 11 and on Linux (with
QT_QPA_PLATFORMTHEME=gtk3as the KDE Plasma one did not run into that)