Skip to content

fix(macOS): hide dock icon when closing settings with ⌘+W #9702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
i2h3 merged 1 commit into from
Mar 26, 2026

fix(macOS): hide dock icon when closing settings with ⌘+W

30b7fbf
Select commit
Loading
Failed to load commit list.
Merged

fix(macOS): hide dock icon when closing settings with ⌘+W #9702

fix(macOS): hide dock icon when closing settings with ⌘+W
30b7fbf
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 26, 2026 in 44m 53s

Quality Gate failed

Failed conditions
31 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 541 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "navigationScroll" of type "class QScrollArea *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbl&open=AZ0phKB-J_U2KSmzHsbl&pullRequest=9702

Check warning on line 554 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "contentScroll" of type "class QScrollArea *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbo&open=AZ0phKB-J_U2KSmzHsbo&pullRequest=9702

Check warning on line 360 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "account" of type "const class OCC::Account *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbd&open=AZ0phKB-J_U2KSmzHsbd&pullRequest=9702

Check warning on line 436 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbL&open=AZ0phKB-J_U2KSmzHsbL&pullRequest=9702

Check warning on line 284 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "contentContainer" of type "class QWidget *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbb&open=AZ0phKB-J_U2KSmzHsbb&pullRequest=9702

Check warning on line 75 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "width" of type "int" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbR&open=AZ0phKB-J_U2KSmzHsbR&pullRequest=9702

Check warning on line 129 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "window" of type "const class QWidget *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbV&open=AZ0phKB-J_U2KSmzHsbV&pullRequest=9702

Check failure on line 222 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "=default" instead of the default implementation of this special member functions. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbY&open=AZ0phKB-J_U2KSmzHsbY&pullRequest=9702

Check warning on line 126 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "event" of type "class QMouseEvent *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbU&open=AZ0phKB-J_U2KSmzHsbU&pullRequest=9702

Check warning on line 177 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "accountSpacer" of type "class QWidget *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbW&open=AZ0phKB-J_U2KSmzHsbW&pullRequest=9702

Check failure on line 531 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbi&open=AZ0phKB-J_U2KSmzHsbi&pullRequest=9702

Check warning on line 77 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "widget" of type "const class QWidget *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbS&open=AZ0phKB-J_U2KSmzHsbS&pullRequest=9702

Check warning on line 535 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "navigationLayout" of type "class QVBoxLayout *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbj&open=AZ0phKB-J_U2KSmzHsbj&pullRequest=9702

Check warning on line 439 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbM&open=AZ0phKB-J_U2KSmzHsbM&pullRequest=9702

Check warning on line 531 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "navigationContainer" of type "class QWidget *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbh&open=AZ0phKB-J_U2KSmzHsbh&pullRequest=9702

Check warning on line 92 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace constant with "std::numbers::phi_v<float>". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbT&open=AZ0phKB-J_U2KSmzHsbT&pullRequest=9702

Check failure on line 551 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbn&open=AZ0phKB-J_U2KSmzHsbn&pullRequest=9702

Check warning on line 53 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "widget" of type "const class QWidget *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbO&open=AZ0phKB-J_U2KSmzHsbO&pullRequest=9702

Check warning on line 518 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "mainLayout" of type "class QHBoxLayout *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbf&open=AZ0phKB-J_U2KSmzHsbf&pullRequest=9702

Check failure on line 535 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbk&open=AZ0phKB-J_U2KSmzHsbk&pullRequest=9702

Check warning on line 232 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this method "resizeEvent" to simply inherit it. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbZ&open=AZ0phKB-J_U2KSmzHsbZ&pullRequest=9702

Check warning on line 232 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "event" of type "class QResizeEvent *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsba&open=AZ0phKB-J_U2KSmzHsba&pullRequest=9702

Check failure on line 554 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbp&open=AZ0phKB-J_U2KSmzHsbp&pullRequest=9702

Check warning on line 430 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid explicitly specifying the template arguments by relying on the class template argument deduction. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbe&open=AZ0phKB-J_U2KSmzHsbe&pullRequest=9702

Check failure on line 518 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0phKB-J_U2KSmzHsbg&open=AZ0phKB-J_U2KSmzHsbg&pullRequest=9702
View more details on SonarQubeCloud