fix(gui/settings): use different palette colour for backgrounds#9703
Merged
fix(gui/settings): use different palette colour for backgrounds#9703
Conversation
nilsding
requested review from
Aiiaiiio,
camilasan,
i2h3 and
mgallien
as code owners
Member
Author
|
/backport to stable-33.0 |
mgallien
approved these changes
Mar 26, 2026
QPalette::AlternateBase looks too off on macOS Tahoe with dark mode. also tried QPalette::Midlight, but that colour seems to be influenced by the configured wallpapaer which could look really odd :/ Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Because of course QPalette::Light is too light on dark mode on that platform. Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
nilsding
force-pushed
the
bugfix/9683/settings-colours
branch
from
1f92386 to
75c8ace
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9703.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QPalette::AlternateBase looks too off on macOS Tahoe with dark mode -- and of course QPalette::Light looks more off on Windows than it did with AlternateBase, so let's keep using that for now on Windows...
Resolves #9683.