[stable-33.0] fix(macOS): hide dock icon when closing settings with ⌘+W#9708
Merged
i2h3 merged 1 commit intostable-33.0from Mar 26, 2026
Merged
[stable-33.0] fix(macOS): hide dock icon when closing settings with ⌘+W#9708i2h3 merged 1 commit intostable-33.0from
i2h3 merged 1 commit intostable-33.0from
Conversation
The ⌘+W shortcut was connected to QDialog::accept(), which internally calls hide() and emits QEvent::Hide. The ForegroundBackground event filter only listens for QEvent::Close, so the dock icon remained visible. Clicking the window's close button works correctly because it sends QEvent::Close directly. Connecting the shortcut to close() instead of accept() ensures QEvent::Close is sent, making ⌘+W behave identically to the close button: the event filter fires, ToBackground() is called, and the dock icon disappears. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
backportbot
bot
requested review from
Aiiaiiio,
camilasan and
i2h3
as code owners
backportbot
bot
added
bug
os: 🍎 macOS
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #9702