feat(images): Build multi-arch images #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SystemKeeper
force-pushed
the
feat/noid/multi-arch-images
branch
2 times, most recently
from
832b55f to
5ee2447
Compare
Signed-off-by: Marcel Müller <[email protected]>
Signed-off-by: Marcel Müller <[email protected]>
SystemKeeper
force-pushed
the
feat/noid/multi-arch-images
branch
from
5ee2447 to
8d6d1e7
Compare
nickvergessen
approved these changes
Jan 8, 2025
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Looks good enough to me, but I have no clue what it changes and why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example run with changed Dockerfile: https://github.com/nextcloud/docker-ci/actions/runs/12613287202/job/35150961232#step:3:207
All runners now support
binfmtthat is needed to build multi-arch images (that support was missing back in August when the PR was created).