Skip to content

feat(translation): FIx handling of android library custom path #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Nov 14, 2024
Merged

feat(translation): FIx handling of android library custom path #682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions translations/handlePlainTranslations.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ versions="$default_branch $(git branch -r | grep -E "origin\/stable\-[0-9\.]+$"
if [ -d src/main/res ]; then
rm -rf src/main/res/values-*/strings.xml
fi
# Android library
if [ -d library/src/main/res ]; then
rm -rf library/src/main/res/values-*/strings.xml
fi
# Android talk app
if [ -d app/src/main/res ]; then
rm -rf app/src/main/res/values-*/strings.xml
Expand Down Expand Up @@ -59,6 +63,35 @@ if [ $1 = "nextcloud" -a $2 = "android" ]; then
rm -rf stable-values
fi

if [ $1 = "nextcloud" -a $2 = "android-library" ]; then
mkdir stable-values
for version in $versions
do
git checkout $version

cp library/src/main/res/values/strings.xml stable-values/$version.xml
done

cd stable-values
echo '<?xml version="1.0" encoding="utf-8"?>
<resources>' >> combined.xml

grep -h "<string" *.xml | sort -u | sed s'#\t# #'g >> combined.xml

# plurals are hard to compare, so we take only master/main ones
awk '/<plurals/,/<\/plurals>/' "$default_branch.xml" >> combined.xml

echo "</resources>" >> combined.xml

cat combined.xml

mv combined.xml ../library/src/main/res/values/strings.xml

cd ..

rm -rf stable-values
fi

if [ $1 = "nextcloud" -a $2 = "talk-android" ]; then
mkdir stable-values
for version in $versions
Expand Down Expand Up @@ -97,6 +130,11 @@ if [ $1 = "nextcloud" -a $2 = "android" ]; then
git checkout $default_branch
fi

if [ $1 = "nextcloud" -a $2 = "android-library" ]; then
git checkout -- library/src/main/res/values/strings.xml
git checkout $default_branch
fi

if [ $1 = "nextcloud" -a $2 = "talk-android" ]; then
git checkout -- app/src/main/res/values/strings.xml
git checkout $default_branch
Expand Down Expand Up @@ -133,6 +171,12 @@ do
mv src/main/res/values-de-rDE src/main/res/values-de
fi

# for the Android library rename the informal german to the formal version
if [ -d library/src/main/res ]; then
rm -rf library/src/main/res/values-de
mv library/src/main/res/values-de-rDE library/src/main/res/values-de
fi

# for the Android talk and files app rename the informal german to the formal version
if [ -d app/src/main/res ]; then
rm -rf app/src/main/res/values-de
Expand Down