Skip to content

Conversation

@mgallien
Copy link
Contributor

No description provided.

@rakekniven
Copy link
Member

Looks like

if [ $(jq '.translations | keys[]' l10n/en_GB.json | grep '\.\.\.' | wc -l) -ne 0 ]; then

@rakekniven
Copy link
Member

Fine for me. Thanks Matthieu

Copy link
Member

@nilsding nilsding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'd like to also add that check to our CI so we can catch it early on and not be surprised about the translations never being updated ;-)

https://github.com/nextcloud/desktop/blob/master/.github/workflows/check-translations.yml

@nickvergessen
Copy link
Member

and not be surprised about the translations never being updated

Tobi and me receive error emails every night. But yeah if you can do it on CI that would be better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgallien
Copy link
Contributor Author

mgallien commented Aug 1, 2025

closing this PR in favor of doing it with CI
for now only Qt managed translations are checked in CI
nextcloud/desktop#8522

@mgallien mgallien closed this Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants