feat: allow editing of submission by the user

[tpokorra]

related to #1110

• show checked radio buttons and check boxes with previous answer
• update submission and answers, don't delete and create submission or answers
• allow deletion of submission
• rebase to main branch
• resolve Lint and Unit Test Job Failures
• add Unit tests for new functionality

[Chartman123]

I just added some comments on the Changelog and the translations :)

I didn't have a closer look for now.

But one thing that I already saw: you seem to delete an existing submission instead of updating it. I'm not quite sure if that's the way to go here.

[tpokorra]

Thank you @Chartman123
I will fix those issues.

The whole pull request is not fully functional yet.
I still need to get the vue components to display the previously submitted answers.

[Chartman123]

@tpokorra yes no problem :) you can have a look at the PR implementing the local storage how the components get their values there. And for getting the values from the database and pass them to the front-end can be seen in the results view...

[tpokorra]

TODO list:

• show checked radio buttons and check boxes with previous answer
• update answer, don't delete and create answer
• allow deletion of answer

[Chartman123]

@tpokorra I've added your checklist to first post :) And btw thank you very much for your contribution to this project 👍🏻

I've also run the automated check workflows for this PR so that you can easily find problems with your commits. Please have a look at the failed checks. If you have questions about some of the checks feel free to ask 🙂

[Chartman123]

@tpokorra please don't merge the main branch into your branch. Use git rebase to update your branch to the latest commits to main :)

You can also use git rebase to squash your commits into a single one so that the commit history on your main branch stays clean :)

You can try git rebase -i main to do this :) After that you'll have to use git push --force to push the rebased commits to your branch.

[tpokorra]

@Chartman123
I am trying to run the unit tests locally, so that I can fix and extend them.

I have a small question: why is there a reference to Test\TestCase in most test files?

I get this error:

tim03-nextcloud@h13:~/nextcloud/apps/forms$ composer test:unit
> phpunit -c tests/phpunit.xml
PHP Fatal error:  Uncaught Error: Class "Test\TestCase" not found in /home/pacs/tim03/users/nextcloud/nextcloud/apps/forms/tests/Unit/Activity/ActivityManagerTest.php:41
Stack trace:

If I change it from Test\TestCase to PHPUnit\Framework\TestCase it just complains about the next file.

Am I missing something to install?

I ran:

cd nextcloud/apps/forms
composer install
composer dumpautoload -o

phpunit in vendor/bin shows version 9.6.13

[Chartman123]

@tpokorra didn't manage to run the unit tests locally...

Regarding the extends \Test\TestCase you can also find some information in the dev docs: https://docs.nextcloud.com/server/stable/developer_manual/basics/testing.html

[tpokorra]

@Chartman123
Thank you, your hint helped.
I needed to copy the folder tests from https://github.com/nextcloud/server/tree/master/tests to my installation of Nextcloud.
I can now fix the test issues.

[codecov]

Codecov Report

Attention: Patch coverage is 63.15789% with 49 lines in your changes missing coverage. Please review.

Project coverage is 44.12%. Comparing base (39de0d7) to head (38cb8d6).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1690      +/-   ##
============================================
+ Coverage     43.43%   44.12%   +0.68%     
- Complexity      882      919      +37     
============================================
  Files            77       78       +1     
  Lines          3361     3490     +129     
============================================
+ Hits           1460     1540      +80     
- Misses         1901     1950      +49     

[SergioArbarviro]

Hello @tpokorra

I thank you very much for your good work. I fully support this feature, which I believe is very important in many use cases. Do you need help, and if so, where?

[AIlkiv]

Thank you for your work. A few comments from me.

[AIlkiv]

1. It makes sense to move the ownership check to submission before validateSubmission
2. It is better to rewrite this check to $this->submissionMapper->findById($submissionId). This will cover situations with multiple submissions and is a faster method.

[AIlkiv]

In what cases can this be? When deleting a submission?

[AIlkiv]

To generate fewer database queries, before foreach where the storeAnswersForQuestion method is called, get all the answers in one call through $this->answerMapper->findBySubmission and pass here

[AIlkiv]

I will try to propose a simpler solution for this method

$deletingStoredAnswers = [];
foreach ($storedAnswers as $storedAnswer) {
$deletingStoredAnswers[$storedAnswer->getText() ] = $storedAnswer
}

[AIlkiv]

delete

[AIlkiv]

delete

[AIlkiv]

revert

[AIlkiv]

if (array_key_exists($answerText, $deletingStoredAnswers)) {
unset($deletingStoredAnswers[$answerText])
continue; // answer already been stored
}

$answerEntity->setText($answerText);
$this->answerMapper->insert($answerEntity);

[AIlkiv]

if (!empty( $deletingStoredAnswers) {
foreach ( $deletingStoredAnswers as $storedAnswer) {
$this->answerMapper->delete($storedAnswer);
}
}

[AIlkiv]

if this only works for cases where only one submission is allowed. Add !$form->getSubmitMultiple() here

[Chartman123]

@tpokorra I'll try to get this branch back from the forked repo into a feature branch in our upstream repo if it's fine for you :) Then we can start working on your great contributions to get it in shape and being able to release it soon :)

[Chartman123]

Closed in favor of #2715