fix(trash): Fix deleting items from public share with write access

[come-nc]

When no user in session, default to owner.

Fix #3544 hopefully.

[kyteinsky]

💚 thanks

[artonge]

I don't think it makes sense. If an anonymous user deleted a file from a public share, then we should say so and not accuse the owner of the public share.
Maybe using a placeholder like "anonymous public user" would be better?

[come-nc]

@kyteinsky Can you test the behavior when using '' instead of $owner?
It looks like the rest of the code considers deleted_by as optional.

[kyteinsky]

file_4 was deleted with '', file_5 with null
both have the same db state for deleted_by too

[come-nc]

file_4 was deleted with '', file_5 with null both have the same db state for deleted_by too

The parameter is typed as string on groupfolders side, so I’m using ''.
I forced push a version using that instead of $owner.

[kyteinsky]

maybe we can also change the term "Unknown" to "Anonymous Public User" like @artonge suggested?
but it might affect deletions from a previous version where this field was not there and values are set to null by default on upgrade.
a third state may be useful here somehow: unknown, user and "anonymous".

Or "Unknown" is fine too.

[kyteinsky]

/backport to stable31

[kyteinsky]

/backport to stable30

[kyteinsky]

/backport to stable29

[backportbot]

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/3604/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 574c909c

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3604/stable30

Error: No changes found in backport branch

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[backportbot]

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/3604/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 574c909c

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3604/stable29

Error: No changes found in backport branch

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[ReneFloitgraf]

I think the (new) fix still doesn't work!

Steps to reproduce:

1. Share a folder within a groupfolder via link with rights to upload files.
2. Use link in another browser and upload a file.
3. Delete the uploaded file as a regular nextcloud-user.

The file will still not be removed until the app "deleted files" is deactivated!

Groupfolder - MoveToTrash - Error.log

[come-nc]

I think the (new) fix still doesn't work!

Steps to reproduce:

1. Share a folder within a groupfolder via link with rights to upload files.
2. Use link in another browser and upload a file.
3. Delete the uploaded file as a regular nextcloud-user.

The file will still not be removed until the app "deleted files" is deactivated!

Groupfolder - MoveToTrash - Error.log

This is specific to objectstore storage, and comes from #3481
I think the check is_callable is wrong, it only checks that the array looks like a callable, not that the method actually exists.
Can you open a new issue for this?