feat: performance tuning for ACL rule derivation #4396
Merged
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimized ACLManager::getRelevantRulesForPath() by replacing repeated array_merge() + array_unique() calls with map-style deduplication ($allPaths[$path] = true) and passing array_keys() to getRules(). This avoids repeated large-array rebuilds Signed-off-by: Rello <[email protected]>
Contributor
Author
|
/backport to stable31 |
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Contributor
Author
|
|
provokateurin
approved these changes
Feb 11, 2026
Member
|
/backport to stable33 |
Member
|
/backport to stable32 |
This was referenced Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized ACLManager::getRelevantRulesForPath() by replacing repeated array_merge() + array_unique() calls with map-style deduplication ($allPaths[$path] = true) and passing array_keys() to getRules(). This avoids repeated large-array rebuilds
Blackfire Profiling on NC31 with 30k Team Folders + 30 ACLs
Before:
After:
