Add deletion of group_folders_groups in FolderManager#4404
Add deletion of group_folders_groups in FolderManager#4404provokateurin merged 5 commits intonextcloud:masterfrom
Conversation
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Looks good, but if you don't mind, could you check the other tables as well? They don't seem to be cleaned up either, so this would be nice for completeness.
|
I've checked the other tables and deleted entries related to that folder. The only entries I haven't deleted are those in the
The same issue occurs with 'normal' folders and 'normal' files outside group folders, so I think the problem is in the Files app. These entries may be kept in the database for logging purposes, so I'm not sure if deleting data from oc_group_folders_trash is appropriate. |
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Please wrap everything into a transaction, to avoid left-over data if one of the queries fails.
kevin-256
force-pushed
the
master
branch
2 times, most recently
from
f81ef33 to
8f86e27
Compare
Automatically removes associated permissions upon groupfolder deletion to maintain database consistency and cleanliness. Signed-off-by: Kevin <76160206+kevin-256@users.noreply.github.com>
…es from other tables Added deletion of folder entries from the `oc_group_folders_manage` and `oc_group_folders_trash` tables during folder removal. Also reordered the deletion sequence in case foreign key constraints are added to the database in the future. Signed-off-by: Kevin <76160206+kevin-256@users.noreply.github.com>
…oup_folders_trash and group_folders_versions Signed-off-by: kevin-256 <76160206+kevin-256@users.noreply.github.com>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Kevin <76160206+kevin-256@users.noreply.github.com>
Signed-off-by: provokateurin <kate@provokateurin.de>
2 participants
Automatically removes associated permissions upon groupfolder deletion to maintain database consistency and cleanliness.