enh(pagination): add loading guard, total count, jump to page#4481
Open
benjaminfrueh wants to merge 1 commit intomasterfrom
Open
enh(pagination): add loading guard, total count, jump to page#4481benjaminfrueh wants to merge 1 commit intomasterfrom
benjaminfrueh wants to merge 1 commit intomasterfrom
Conversation
383a9c8 to
e17f288
Compare
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
e17f288 to
74a22f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the pagination in the admin settings UI, making it usable for instances with a large number of team folders.
Changes
Backend
countAllFolders()toFolderManagerto get the total folder countGET /folders/countendpoint inFolderController\d+requirement toGET /folders/{id}to prevent route conflict with/folders/countFrontend
goToPageto prevent duplicate entries on clicks before loading finishesScreenshot