Open
Conversation
solracsf
requested review from
a team,
nfebe,
provokateurin,
sorbaugh and
susnux
and removed request for
a team
solracsf
added
3. to review
skjnldsv
approved these changes
Mar 30, 2026
susnux
reviewed
Mar 30, 2026
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
force-pushed
the
includeFileIdRouteParams
branch
from
478a350 to
f0afc55
Compare
Member
Author
|
/backport to stable33 |
Member
Author
|
Fix for PHPstan: #4534 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When clicking a folder in the Team Folders view, the
goToRoutecall omitted thefileidroute param. Without it, the resolved route/files?dir=/Xcan collide with stale router state from a previous navigation, causing Vue Router to silently drop it as aNavigationDuplicated.Adding
fileidmakes the target route/files/123?dir=/X, which is structurally distinct and navigates correctly.On
stable32:groupfolders/src/actions/openGroupfolderAction.ts
Line 24 in 1ef5993
Returning
null cast to booleanevaluates as falsy at runtime. The v3.xFileActionexecutor treated a falsy result as "action failed" and did not record this navigation as the successful result of a default action. This meant the router's state wasn't tied to this specific action's outcome, so the stale-route issue didn't surface before.Fix #4499