fix(docs): incorrect Default column in persistence values table#698
Merged
wrenix merged 1 commit intonextcloud:mainfrom Feb 26, 2025
Merged
fix(docs): incorrect Default column in persistence values table#698wrenix merged 1 commit intonextcloud:mainfrom
wrenix merged 1 commit intonextcloud:mainfrom
Conversation
wrenix
changed the title
wrenix
requested changes
Feb 20, 2025
Collaborator
wrenix
left a comment
wrenix
left a comment
There was a problem hiding this comment.
you need to bump the Chart version (with a patch level). because you make a change in the directory.
Do you like to decrease the last/Default column in the markdown file? (remove spaces and - in the header?)
Contributor
Author
|
Thanks for the input. I've pushed new commits now. Please tell me if I need to squash them. |
Collaborator
|
Squash is not importend (i prefer). But you habe to sign-off you last two commits. |
Fixes nextcloud#695 Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
wrenix
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes some typos in the chart's README.md.
Benefits
Makes the documentation more accurate.
Possible drawbacks
None.
Applicable issues
Fixes #695
Additional information
n/a
Checklist
Chart.yamlaccording to semver.