-
Notifications
You must be signed in to change notification settings - Fork 301
Feat: add support for extraManifests #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wrenix
merged 12 commits into
nextcloud:main
from
thomascizeron:feat/add-extraManifests
Nov 26, 2025
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bfa9d34
➕ Add extraManifests support
thomascizeron f9de6c1
🆙 Bump Chart version
thomascizeron 352a935
👐 Allow for multiline string and yaml objects
thomascizeron f30591b
⚙️ Include new test in github workflow
thomascizeron 16a0b16
🩹 Fix: rename file and no nident
thomascizeron 24ea305
➕ Add extraManifests support for maps
thomascizeron 67c8dee
🩹 Fix: use base64 secret for test-values
thomascizeron 892b4c4
🩹 Fix: use same flags as other tests
thomascizeron 2ae7475
fix: simplify and test template everywhere
wrenix 5e959f0
for e2e test hardcoded namens are required
wrenix feb2265
again
wrenix eeba347
Merge branch 'main' into feat/add-extraManifests
wrenix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| {{- /* | ||
| Renders extra manifests provided by the user in values.yaml under extraManifests. | ||
| extraManifests can be a map (keyed by manifest name) or a list of manifests. | ||
| If a map, each key is the name of the manifest. | ||
| If an array, each item is a manifest, which can be a string (YAML block) or a YAML object. | ||
| */ -}} | ||
| {{- range $manifest := .Values.extraManifests }} | ||
| --- | ||
| {{- if kindIs "string" $manifest }} | ||
| {{ tpl $manifest $ }} | ||
| {{- else }} | ||
| {{ tpl (toYaml $manifest) $ }} | ||
| {{- end }} | ||
| {{- end }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| fullnameOverride: nextcloud | ||
|
|
||
| nextcloud: | ||
| host: nextcloud | ||
| trustedDomains: | ||
| - 'nextcloud.nextcloud.svc.cluster.local' | ||
| - 'nextcloud' | ||
|
|
||
| extraManifests: | ||
| my-config-map: | | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: custom-config | ||
| labels: | ||
| {{- include "nextcloud.labels" ( dict "component" "app" "rootContext" $ ) | nindent 4 }} | ||
| data: | ||
| customKey: customValue | ||
| my-secret: | ||
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: '{{ template "nextcloud.fullname" . }}-custom-secret' | ||
| data: | ||
| secretKey: c2VjcmV0VmFsdWU= |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| fullnameOverride: nextcloud | ||
|
|
||
| nextcloud: | ||
| host: nextcloud | ||
| trustedDomains: | ||
| - 'nextcloud.nextcloud.svc.cluster.local' | ||
| - 'nextcloud' | ||
|
|
||
| extraManifests: | ||
| - | | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: custom-config | ||
| labels: | ||
| {{- include "nextcloud.labels" ( dict "component" "app" "rootContext" $ ) | nindent 4 }} | ||
| data: | ||
| customKey: customValue | ||
| - apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: '{{ template "nextcloud.fullname" . }}-custom-secret' | ||
| data: | ||
| secretKey: c2VjcmV0VmFsdWU= |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.